perf(471): Add duration metrics for wasm abi calls #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulakowski
reviewed
Oct 30, 2023
crates/core/src/host/mod.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Display)] | ||
| pub enum SysCall { |
Contributor
There was a problem hiding this comment.
I'd love to reconcile this with
| Identity, | ||
| Address, | ||
| TransactionType, | ||
| SysCall, |
Contributor
There was a problem hiding this comment.
We've waffled a lot on calling this syscalls vs abicalls vs... what. And even in this PR you say SysCall here but wasm_abi_call elsewhere.
Let's pick one.
Collaborator
Author
There was a problem hiding this comment.
It's really an abi call. I'll update.
Contributor
There was a problem hiding this comment.
I would argue it's really a syscall where SpacetimeDB is the OS. Happy to resolve the bikeshedding in a separate PR though.
kulakowski
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471.
Description of Changes
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.